Fix minor issues from review in PR se-sic#137

Also extend documentation in the source code for the edge-construction algorithm for better comprehensibility. Signed-off-by: Thomas Bock <[email protected]>
fehnkera · Sep 23, 2020 · 13777fd · 13777fd
1 parent 9feae29
commit 13777fd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tests/test-networks-author.R b/tests/test-networks-author.R
@@ -245,7 +245,8 @@ test_that("Network construction of the undirected but temorally ordered author-c
     proj.conf = ProjectConf$new(CF.DATA, CF.SELECTION.PROCESS, CASESTUDY, ARTIFACT)
     proj.conf$update.value("artifact.filter.base", FALSE)
     net.conf = NetworkConf$new()
-    net.conf$update.values(updated.values = list(author.relation = "cochange", respect.temporal.order = TRUE))
+    net.conf$update.values(updated.values = list(author.relation = "cochange", author.directed = FALSE,
+                                                 respect.temporal.order = TRUE))
 
     ## construct objects
     proj.data = ProjectData$new(project.conf = proj.conf)
@@ -328,7 +329,7 @@ test_that("Network construction of the directed author-cochange network without
     proj.conf$update.value("artifact.filter.base", FALSE)
     net.conf = NetworkConf$new()
     net.conf$update.values(updated.values = list(author.relation = "cochange", author.directed = TRUE,
-                                               respect.temporal.order = FALSE))
+                                                 respect.temporal.order = FALSE))
 
     ## construct objects
     proj.data = ProjectData$new(project.conf = proj.conf)

diff --git a/util-networks.R b/util-networks.R
@@ -967,7 +967,8 @@ construct.edge.list.from.key.value.list = function(list, network.conf, directed
             ## construct edge list
             edges = apply(combinations, 2, function(comb) {
 
-                ## iterate over each item of the current combination
+                ## iterate over each of the two data vertices of the current combination to determine the edges
+                ## for which it is the sender of the edge and use the second one as the receiver of the edge
                 edges.by.comb.item = lapply(comb, function(comb.item) {
                     ## basic edge data
                     edge = data.frame(comb.item, comb[comb != comb.item])