Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.rst #338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nwekealex65
Copy link

@nwekealex65 nwekealex65 commented Mar 13, 2024

Add documentation for passive_declares config value.
fixes issue #245.

This pull request aims to fix issue #245 which addresses documentation for configuring Fedora Messaging by adding a passive_declares option to be set true for vhost users

Changes Made
Added a reminder to the installation.rst file emphasizing the importance of setting passive_declares to true in the Fedora Messaging configuration.
Provided clear instructions for users to locate the /etc/fedora-messaging/config.toml file and set the passive_declares option to true.

@nwekealex65
Copy link
Author

Not sure why the tests are failing

@abompard
Copy link
Member

Not sure why the tests are failing

you can ignore the rpm-build and testing-farm failures for now. Please use "-s" to sign your commits, this will add a Signed-Off-By tag in the commit message and the DCO test will pass.

@nwekealex65
Copy link
Author

Did you review the documentation? All test passes now. Does it mean the pull request has been merged?

@abompard
Copy link
Member

The DCO test is still not passing, see my comment above.

@nwekealex65
Copy link
Author

The DCO test is still not passing, see my comment above.

Okay seen

Add documentation for passive_declares config value.

Signed-off-by: nwekealex65 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants