doc: Update usage.rst #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for how to consume messages with a message schema
abompard
requested changes
Mar 13, 2024
docs/tutorial/usage.rst
Outdated
| Validating Messages Against Schema | ||
| ---------------------------------- | ||
|
|
||
| Before processing a received message, consumers must validate it against the associated message schema. This ensures that the message structure conforms to the expected format defined in the schema. The `jsonschema` library is commonly used for this purpose within the Fedora Messaging project. |
There was a problem hiding this comment.
This is actually not true, the message is already validated as part of the consuming process (in message.get_message().
There was a problem hiding this comment.
So I should remove this part? any suggestions?
There was a problem hiding this comment.
Yeah, but that means removing everything actually, because the introduction in "Consuming Messages" is wrong too: it mentions how consumers can validate received messages, and they don't need to.
|
This isn't really what Jeremy mentions in the ticket comment. |
|
@abompard I made some changes to this, can review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for how to consume messages with a message schema. This addresses #229. It explains how to consume message schema