-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign apps.fp.o #58
Conversation
17a603a
to
e386a17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just recommend squashing the commits, when you think it is ready for merge
This makes it a very long list that's not very fun to look at :( |
@pypingou any suggestions? What about adding a fedmenu style list at the the top with quick links? |
@mymindstorm to be honest not really, it's a tough page to (re)design :( |
@pypingou been thinking about this for a while, and I'm not really sure how to make a list of things "fun" (well, not without sacrificing UX like the current design does). Anyway, I looked around at what other people did with really big lists and have a few ideas before giving up and closing this completely unless you have some ideas.
|
I think better is the enemy of good here. This is indeed a big list but the current page has legibility and accessibility issues that are solved by this redesign / simpler design. Incremental improvements could come later. Moreover the current page is already outdated (https://discussion.fedoraproject.org is not there for example). |
That's mostly the reason I made this in the first place. I know the design isn't the best, but I want to be able to ctrl + f and find a service quickly. I also can't actually click on all of the services sometimes because my laptop's screen is too small. |
@mymindstorm May I suggest that you squash all your commits as requested so that this can get approved and merged. Then I think we should discuss adding new services and doing some re-ordering. |
4ce2015
to
6f08678
Compare
Update yaml2json.py Add favicon Make jquery local Style changes Update build scripts and packaging Also update data.json fix capitalization in data.yaml add missing images Fix packages link don't break fedmenu build script update build script instructions Mobile support, center icons, fix scripts Section description hidden in popover
6f08678
to
9791fe8
Compare
@Siosm it looks like this doesn't matter anymore as apps.fp.o will be deprecated. |
I am not aware that we are, but fedmenu is being deprecated anyway, it has already been removed from a number of our applications. apps.fp.o is also going to be retired, in favor of a page in the infra docs hosted at docs.fedoraproject.org. The first work toward this can be seen at: https://pagure.io/infra-docs-fpo/pull-request/1 |
I just got a notification on this PR. No idea what is the status here and what are the future plans for https://apps.fedoraproject.org but for the record, some time ago I did an unofficial rewrite of the apps page, so please allow me to make a shameless plug here: Instance: https://fedora-apps.netlify.app/ It never got accepted and used in production but in case anybody was interested in moving forward on that front, please let me know. |
Closes #37
025f23d closes #55 #56 fedora-infra/fedmenu#22
This is my initial attempt to make apps.fp.o more readable. I'm not a designer, so it needs a bit of work.
Screenshot
The Ipsilon link is broken, should it go here?
Should https://discussion.fedoraproject.org/ and https://budget.fedoraproject.org/ be added?