Gateway has built-in LDK lightning node (and it generates invoices rather than the client) #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
changed the title
tvolk131
changed the title
tvolk131
force-pushed
the
gateway_generates_invoice
branch
from
83d5561 to
fc29f80
Compare
| invoice.expiry_time().as_secs() | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Need to verify same payment hash
There was a problem hiding this comment.
Whoops! Good catch, thanks!
| ); | ||
| } | ||
|
|
||
| let invoice: Bolt11Invoice = response.json().await?; |
There was a problem hiding this comment.
probably makes sense to have this as a json object so it can be more extensible in the future
| @@ -37,6 +37,7 @@ ln-gateway = { version = "0.3.0-alpha", package = "fedimint-ln-gateway", path = | |||
| ldk-node = { package = "fedimint-ldk-node", version = "0.1.0" } | |||
| futures = "0.3" | |||
| lightning-invoice = "0.26.0" | |||
| lightning-invoice29 = { package = "lightning-invoice", version = "0.29.0" } | |||
There was a problem hiding this comment.
ldk-node re-exports lightning invoice. Can probably just use that
There was a problem hiding this comment.
Requires #4354 since we're currently using fedimint-ldk-node v0.1.0 which re-exports lightning-invoice v0.23.0 instead of v0.29.0. Leaving this open until that PR is merged.
tvolk131
force-pushed
the
gateway_generates_invoice
branch
from
fc29f80 to
e139d44
Compare
tvolk131
force-pushed
the
gateway_generates_invoice
branch
from
a4a2c39 to
05068d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERY broken, do not merge!