Move the credential chooser to after the popup/redirect #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannhof
reviewed
Jun 4, 2024
README.md
Outdated
| }, | ||
| ] | ||
| } | ||
| }); | ||
| ``` | ||
| The browser looks into the credential store and sees that there is a credential this is effective for `example.com` from `login.idp.net`. |
There was a problem hiding this comment.
Suggested change
| The browser looks into the credential store and sees that there is a credential this is effective for `example.com` from `login.idp.net`. | |
| The browser looks into the credential store and sees that there is a credential that is effective for `example.com` from `login.idp.net`. |
README.md
Outdated
|
|
||
| ### Scenario 2: User intends to link to an identity provider they are already logged in to | ||
| ### Scenario 2: User logs in with one of many identity providers, or other types of credential |
There was a problem hiding this comment.
I'm not 100% sure what Scenario 2 adds to the proposal. What is it that we want user agents to implement here?
There was a problem hiding this comment.
- Collecting IdentityCredentials from the credential store.
- Flexibility to allow the UA to show multiple credential types in a credential chooser.
| In this scenario the user has made some indication to the site that they want to log in. | ||
| The specifics of that interaction dictate what Credential types are appropriate. For sake of discussion, let's say the credentials defined here and a PasswordCredential would be good. | ||
| The page then calls the following: | ||
| ### Scenario 3: User intends to link to an identity provider they are already logged in to |
There was a problem hiding this comment.
Same with Scenario 3, what is the delta to FedCM?
There was a problem hiding this comment.
- For IDPs it is easier to work with, despite having the same UX.
Co-authored-by: Johann Hofmann <[email protected]>
bvandersloot-mozilla
force-pushed
the
bvandersloot-restructure-discovery
branch
from
7923a67
to
445f9dc
Compare
johannhof
approved these changes
Jun 12, 2024
| loginTarget: "redirect", | ||
| }, | ||
| ] | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| This example shows the use perfect for a "Log in with Foo" button (use case #1, and use case #2), where one identity provider is presented, and if the user has not already logged in, they may be redirected to that provider's login page. This redirect behavior is only permitted when there is only one provider in the list. A provider with `loginURL` field indicates that this is the expected mode. If `loginURL` is present, but `origin` is not, its value can be inferred as the origin of the link. | ||
| This example shows the use perfect for a "Log in with Foo" button, where one identity provider is presented, and if the user has not already logged in, they may be redirected to that provider's login page. This redirect behavior is only permitted when there is only one provider in the list. A provider with `loginURL` field indicates that this is the expected mode. If `loginURL` is present, but `origin` is not, its value can be inferred as the origin of the link. |
There was a problem hiding this comment.
it could be rewritten as "the use of the API that is perfect". "use" as in the noun meaning occasion or need. Agreed that this could be reworded
There was a problem hiding this comment.
Suggested change
| This example shows the use perfect for a "Log in with Foo" button, where one identity provider is presented, and if the user has not already logged in, they may be redirected to that provider's login page. This redirect behavior is only permitted when there is only one provider in the list. A provider with `loginURL` field indicates that this is the expected mode. If `loginURL` is present, but `origin` is not, its value can be inferred as the origin of the link. | |
| This example shows a scenario that is perfect for a "Log in with Foo" button, where one identity provider is presented, and if the user has not already logged in, they may be redirected to that provider's login page. This redirect behavior is only permitted when there is only one provider in the list. A provider with `loginURL` field indicates that this is the expected mode. If `loginURL` is present, but `origin` is not, its value can be inferred as the origin of the link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #28 .
Resolves many of the concerns of #26.
Obviates #23 and #24.