Issue # 290 and improvements over fragment managing on settings page #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setting to change first day of week in reminder calendar
Use RecyclerView to display notes list and add new staggered grid layout
[WIP] Design overhaul
# Conflicts: # gradle.properties # gradle/wrapper/gradle-wrapper.properties # omniNotes/src/main/java/it/feio/android/omninotes/utils/GeocodeHelper.java # omniNotes/src/main/res/raw/changelog.xml # omniNotes/src/main/res/values-de-rDE/strings.xml
Fix end position calculation for title animation in note detail view
Handled the fragment management on settings page.
federicoiosue
force-pushed
the
develop
branch
from
f1307ae to
10825f2
Compare
federicoiosue
force-pushed
the
develop
branch
4 times, most recently
from
24cc141 to
cd90bda
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
b41a380 to
8d9e3c8
Compare
federicoiosue
force-pushed
the
develop
branch
6 times, most recently
from
f42d265 to
cfbdbc4
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
73fc7a0 to
c87d5ee
Compare
federicoiosue
force-pushed
the
develop
branch
4 times, most recently
from
cfb925a to
db0286b
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
0f1f367 to
c8987f1
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
d78a98e to
0168039
Compare
federicoiosue
force-pushed
the
develop
branch
5 times, most recently
from
911df26 to
a6655ce
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
cbb03b8 to
11c97fd
Compare
federicoiosue
force-pushed
the
develop
branch
from
2edb3a1 to
5a0bb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Issue #290 : it seems that earlier development missed to handle the orientation changes while user is seeing the "Password check dialog". As a result we are erasing the data that is stored in "noteTmp" through "save()" method in "onPause" and "onSavedInstanceState". I corrected it to handle the orientation changes.
Improvements over fragment managing on settings page : Here i saw earlier development managed the fragments by itself (i.e by storing the "backstack" and etc). I removed it using the "addbackstack" method which i feel is less error-prone going forward and easy to maintain.