Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Edit/Copy comment" into Game menu #880

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Mar 9, 2021

Alternatively...

  • Edit comment: Double-click on the comment area (the black rectangle at the bottom right)
  • Copy comment to clipboard: Ctrl-Shift-C

This PR is just a workaround for #806 until someone will implement #806 itself.

@hope366
Copy link

hope366 commented Mar 9, 2021

If you write double-byte characters in the comment area, you will not be able to turn analysis on or off.
You can turn the analysis on and off by entering additional half-width characters.

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 10, 2021

  1. Did you turn off IME (Japanese input mode) before hitting SPACE key to toggle pondering?
  2. Would you try the same operations as your previous comment on https://github.com/kaorahi/lizzie/tree/for806_comment_io2 (20824c5) ?

@hope366
Copy link

hope366 commented Mar 10, 2021

I solved it by inputting half-width alphanumeric characters before hitting the space key.
Thank you for your advice.
I tried 20824c5, but I wasn't sure what the difference was before and after it was applied.

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 10, 2021

No! "inputting half-width alphanumeric characters before hitting the space key" is not a solution but just a workaround. Such "bad know-how" makes Lizzie too difficult for typical Go fans who does not have high skill in computers. It is unhappy for us, isn't it? :-)

As I have no Windows machine, I cannot debug issues on Windows unless someone gives me sufficient information. If you would help debugging for not only you but also other nontechnical users, please follow my requests exactly and tell me the results.

(A) On https://github.com/kaorahi/lizzie/tree/for806_comment_io (9b53d93)

  1. Start Lizzie and select Game > Edit Comment.
  2. Input Japanese ("double-width") characters.
  3. Turn off IME (= Turn off "Japanese input mode") and click OK button.
  4. Hit SPACE key.

Can you toggle pondering in Step 4?

(B) On https://github.com/kaorahi/lizzie/tree/for806_comment_io2 (20824c5)

  1. Start Lizzie and select Game > Edit Comment.
  2. Input Japanese ("double-width") characters.
  3. Keeping IME on (= Keeping "Japanese input mode"), click OK button.
  4. Hit SPACE key.

Can you toggle pondering in Step 4?

Be careful: Step 3 is different between (A) and (B).

@hope366
Copy link

hope366 commented Mar 10, 2021

(A) and (B) were each verified by compiling the source code downloaded from the specified links.

In case (A), it was possible to toggle pondering.
In case (B), it was not possible to toggle pondering.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Mar 11, 2021
@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 11, 2021

thx!

How about (B) on https://github.com/kaorahi/lizzie/tree/for806_comment_io3 (32436d5) ?

@hope366
Copy link

hope366 commented Mar 11, 2021

I tried https://github.com/kaorahi/lizzie/tree/for806_comment_io3, but I couldn't switch the pondering with the space key in Japanese input mode.
By the way, the analysis switching button on the lower toolbar works even in the Japanese input mode. (Same for https://github.com/kaorahi/lizzie/tree/for806_comment_io2)

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 11, 2021

Hmm...

On https://github.com/kaorahi/lizzie/tree/for806_comment_io3 (32436d5), I expect that "Japanese input mode" is automatically turned off when you click OK button in Step 3. This gimmick doesn't work?

@hope366
Copy link

hope366 commented Mar 11, 2021

When I clicked the OK button in step 3, the IME display at the bottom right flashed for a moment.
In other words, if you click the OK button, the Japanese input mode will be canceled, but you will soon be in the Japanese input mode again.

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 12, 2021

Oh, strange. I don't think I can solve this issue without help from Windows programmers. Thanks anyway for your reports.

@kaorahi kaorahi mentioned this pull request Mar 12, 2021
@yzyray
Copy link
Contributor

yzyray commented Mar 17, 2021

Maybe we can solve the IME issue by disable LizzieFrame mainPanel's IME, mainPanel.enableInputMethods(false);

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 17, 2021

thx!

@hope366, can you try the above (B) on https://github.com/kaorahi/lizzie/tree/for806_comment_io4 (459cbbf) with both Normal UI and Panel UI?

@hope366
Copy link

hope366 commented Mar 17, 2021

459cbbf
I tried this.
In both normal mode and panel UI mode, IME automatically switches to half-width alphanumeric mode by clicking the "OK" button after full-width input! !!

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Mar 19, 2021
@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 19, 2021

Then 459cbbf seems ok. :)

I added it to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants