-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ES module builds (ESM Support) #2665
base: dove
Are you sure you want to change the base?
Conversation
[pull] dove from feathersjs:dove
Feathersjs dove
- add module.exports for default export
This looks like a good step, thank you. I am seeing the same error locally you can see in CI:
I'm not sure what that means since all those packages have an identical configuration. |
✅ Deploy Preview for feathers-dove canceled.
|
Making a note here that the thing that may be missing is that the ESM and CJS folders each need a { "type": "module|commonjs" } Now that TypeScript seems to support it properly it might also make sense to use full imports with |
This pull request adds ES module builds to all package distributables. It is backwards compatible by still providing the CommonJS version as well but will use ES modules in applications with
"type": "module"
(like the generated app) and with client side bundlers so it can use features like tree shaking.Closes #2748
Closes #2001