fix: check the x-forwarded-proto header for setting the scheme of an …

…url created with url_for
fbraem · Dec 8, 2024 · 555dd35 · 555dd35
1 parent 0fb6fad
commit 555dd35
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 5 deletions.
diff --git a/backend/src/kwai/frontend/apps/_auth.py b/backend/src/kwai/frontend/apps/_auth.py
@@ -29,12 +29,16 @@ async def get_app(
     if asset_file_path is not None:
         return EtagFileResponse(asset_file_path)
 
+    url = request.url_for(APP_NAME, path="")
+    if "x-forwarded-proto" in request.headers:
+        url = url.replace(scheme=request.headers["x-forwarded-proto"])
+
     return templates.TemplateResponse(
         "index.jinja2",
         {
             "application": {
                 "name": APP_NAME,
-                "url": str(request.url_for(APP_NAME, path="")),
+                "url": str(url),
             },
             "request": request,
             "vite": vite,

diff --git a/backend/src/kwai/frontend/apps/_author.py b/backend/src/kwai/frontend/apps/_author.py
@@ -29,12 +29,16 @@ async def get_app(
     if asset_file_path is not None:
         return EtagFileResponse(asset_file_path)
 
+    url = request.url_for(APP_NAME, path="")
+    if "x-forwarded-proto" in request.headers:
+        url = url.replace(scheme=request.headers["x-forwarded-proto"])
+
     return templates.TemplateResponse(
         "index.jinja2",
         {
             "application": {
                 "name": APP_NAME,
-                "url": str(request.url_for(APP_NAME, path="")),
+                "url": str(url),
             },
             "request": request,
             "vite": vite,

diff --git a/backend/src/kwai/frontend/apps/_club.py b/backend/src/kwai/frontend/apps/_club.py
@@ -29,12 +29,16 @@ async def get_app(
     if asset_file_path is not None:
         return EtagFileResponse(asset_file_path)
 
+    url = request.url_for(APP_NAME, path="")
+    if "x-forwarded-proto" in request.headers:
+        url = url.replace(scheme=request.headers["x-forwarded-proto"])
+
     return templates.TemplateResponse(
         "index.jinja2",
         {
             "application": {
                 "name": APP_NAME,
-                "url": str(request.url_for(APP_NAME, path="")),
+                "url": str(url),
             },
             "request": request,
             "vite": vite,

diff --git a/backend/src/kwai/frontend/apps/_coach.py b/backend/src/kwai/frontend/apps/_coach.py
@@ -29,12 +29,16 @@ async def get_app(
     if asset_file_path is not None:
         return EtagFileResponse(asset_file_path)
 
+    url = request.url_for(APP_NAME, path="")
+    if "x-forwarded-proto" in request.headers:
+        url = url.replace(scheme=request.headers["x-forwarded-proto"])
+
     return templates.TemplateResponse(
         "index.jinja2",
         {
             "application": {
                 "name": APP_NAME,
-                "url": str(request.url_for(APP_NAME, path="")),
+                "url": str(url),
             },
             "request": request,
             "vite": vite,

diff --git a/backend/src/kwai/frontend/apps/_portal.py b/backend/src/kwai/frontend/apps/_portal.py
@@ -29,12 +29,16 @@ async def get_app(
     if asset_file_path is not None:
         return EtagFileResponse(asset_file_path)
 
+    url = request.url_for(APP_NAME, path="")
+    if "x-forwarded-proto" in request.headers:
+        url = url.replace(scheme=request.headers["x-forwarded-proto"])
+
     return templates.TemplateResponse(
         "index.jinja2",
         {
             "application": {
                 "name": APP_NAME,
-                "url": str(request.url_for(APP_NAME, path="")),
+                "url": str(url),
             },
             "request": request,
             "vite": vite,