Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks250fixerror #3

Closed
wants to merge 2 commits into from
Closed

Ks250fixerror #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d6c85
Introduce a make command for pre-requisite of verify-replace
fbm3307 Jan 7, 2025
4336754
Fixing the linter error Linter v1.63.1
fbm3307 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion make/go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,8 @@ vet:
.PHONY: verify-replace-run
## downloads all the repos that depend on toolchain-common, installs the current version of the library and runs all the verifications in order to check for compatibility and breaking changes
verify-replace-run:
./scripts/verify-replace.sh;
./scripts/verify-replace.sh;

.PHONY: pre-verify
pre-verify:
echo "No Pre-requisite needed"
2 changes: 1 addition & 1 deletion pkg/status/componentconditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func ValidateComponentConditionReady(conditions ...toolchainv1alpha1.Condition)
if !found {
return fmt.Errorf("a ready condition was not found")
} else if c.Status != corev1.ConditionTrue {
return fmt.Errorf(c.Message) // return an error with the message from the condition
return fmt.Errorf("%s", c.Message) // return an error with the message from the condition
}

return nil
Expand Down
Loading