Skip to content

Commit

Permalink
fix: windows build (#155)
Browse files Browse the repository at this point in the history
* fix: added cross-env

* chore: updated readme

* fix: added rimraf
  • Loading branch information
biddano authored Apr 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 8f47c1f commit 52bf3cf
Showing 3 changed files with 13,868 additions and 13,378 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ import VideoRecorder from 'react-video-recorder'

const App = () => (
<VideoRecorder
onRecordingComplete={videoBlob => {
onRecordingComplete={(videoBlob) => {
// Do something with the video...
console.log('videoBlob', videoBlob)
}}
@@ -100,3 +100,7 @@ Run the storybook demo
```sh
yarn start
```

### Committing

To commit run yarn start then commit. We use Husky to verify before committing.
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -11,11 +11,11 @@
"jest:browser": "jest -c test/browser/jest.config.js",
"test:browser": "start-server-and-test storybook http-get://localhost:6006 jest:browser",
"lint": "eslint .",
"clean": "rm -rf lib",
"clean": "rimraf -rf lib",
"build": "babel src -d lib --copy-files --ignore **/*.stories.js,**/*.test.js,**/*.browser-test.js",
"build:watch": "babel --watch src -d lib --copy-files --ignore **/*.stories.js,**/*.test.js,**/*.browser-test.js",
"prebuild": "yarn run clean",
"prepublish": "NODE_ENV=production yarn run build",
"prepublish": "cross-env NODE_ENV=production yarn run build",
"start": "yarn run storybook",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
@@ -69,6 +69,7 @@
"babel-jest": "^26.3.0",
"babel-loader": "^8.0.5",
"babel-plugin-styled-components": "^1.10.6",
"cross-env": "^7.0.3",
"enzyme": "^3.9.0",
"enzyme-adapter-react-16": "^1.9.1",
"eslint": "^7.9.0",
@@ -89,6 +90,7 @@
"puppeteer": "^1.18.1",
"react": "^16.8.3",
"react-dom": "^16.8.3",
"rimraf": "^3.0.2",
"semantic-release": "^17.2.3",
"start-server-and-test": "^1.7.11",
"styled-components": "4"
Loading

1 comment on commit 52bf3cf

@vercel
Copy link

@vercel vercel bot commented on 52bf3cf Apr 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.