Document streaming api in README #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorsibanda
requested review from
benjumanji,
agourlay,
erickpintor,
evbruno,
lregnier,
nathaniel-may and
faunaee
agourlay
approved these changes
Nov 18, 2020
lregnier
approved these changes
Nov 18, 2020
|
|
||
| The following section provides an example for managing a document stream. | ||
|
|
||
| The streaming API is blocking by default, the choice and mechanism for handling concurrent streams is left to the application developer: |
There was a problem hiding this comment.
If my grammar is sound, I think it should be "are" here:
Suggested change
| The streaming API is blocking by default, the choice and mechanism for handling concurrent streams is left to the application developer: | |
| The streaming API is blocking by default, the choice and mechanism for handling concurrent streams are left to the application developer: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs follow up to #165