Skip to content

Commit

Permalink
fix CI test runs
Browse files Browse the repository at this point in the history
in CI, the tests are run using docker-compose targeting
./concourse/tasks/integration.yml. for instance, to repro locally, i ran
`docker-compose -f concourse/tasks/integration.yml run tests-310`.

however, the faunadb container is brought up by the test's
docker-compose stack because the tests depends_on the database
container. but since the tests don't require the container to be healthy
(merely existent), they fail well before the database container is up.
  • Loading branch information
echo-bravo-yahoo committed Sep 17, 2024
1 parent 8c0c24b commit 595dc3d
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions concourse/tasks/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ services:
image: python:3.10-alpine3.15
container_name: mytests-310
depends_on:
- faunadb
faunadb:
condition: service_healthy
volumes:
- "../../:/tmp/app"
working_dir: "/tmp/app"
Expand All @@ -37,7 +38,8 @@ services:
image: python:3.9.5-alpine3.13
container_name: mytests-39
depends_on:
- faunadb
faunadb:
condition: service_healthy
volumes:
- "../../:/tmp/app"
working_dir: "/tmp/app"
Expand All @@ -53,7 +55,8 @@ services:
image: python:3.8.12-alpine3.13
container_name: mytests-38
depends_on:
- faunadb
faunadb:
condition: service_healthy
volumes:
- "../../:/tmp/app"
working_dir: "/tmp/app"
Expand All @@ -69,7 +72,8 @@ services:
image: python:3.7.11-alpine3.13
container_name: mytests-37
depends_on:
- faunadb
faunadb:
condition: service_healthy
volumes:
- "../../:/tmp/app"
working_dir: "/tmp/app"
Expand All @@ -85,7 +89,8 @@ services:
image: python:3.6.14-alpine3.13
container_name: mytests-36
depends_on:
- faunadb
faunadb:
condition: service_healthy
volumes:
- "../../:/tmp/app"
working_dir: "/tmp/app"
Expand Down

0 comments on commit 595dc3d

Please sign in to comment.