Improves FSL #43
Open
Improves FSL #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we live in a society.
given the way you've approached fql grammars and because you are referencing it within fsl I'd suggest that you rewrite the fql textmate all together. anyway, this improves syntaxes etc.
|
Also, maybe do some additional testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for the varying syntactic structures of
.fslfiles and exposes are larger subset of tokens for custom theming + extendability.Given the way you've approached the
.fqltextmate grammars, there is little wriggle room to do much on that front, it also makes logic within the.fslgrammars more nuanced because of the source include. I'd suggest you go about re-writing.fqlbecause it's largely problematic and you are not injecting correctly nor using the correct naming on tokens.