Fix colorizing summaries when outputted via --include #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed summary outputs do not fully colorize the FQL diagnostic help/hints/text when used with
--include
.Specifically, all "|" and "^" should be red the above example.
Solution
Update the regular expression used for summary colorization to be the same as query errors. To do this, I needed to strip ansi when checking if it is a fql diagnostic line. This isn't ideal, but it's out of scope to revisit the yaml formatting for these at the moment.
While I was here, I expanded the regex to support lines >9.
Result
Summaries:
Errors
Testing
I added a regex test suite for how we detect fql diagnostic lines.