Clean up lint warnings #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryfauna
approved these changes
Dec 18, 2024
ptpaterson
reviewed
Dec 19, 2024
| @@ -52,64 +61,73 @@ class OAuthClient { | |||
| return Buffer.from(randomBytes(20)).toString("base64url"); | |||
| } | |||
|
|
|||
| _handleRedirect({ pathname, res }) { | |||
There was a problem hiding this comment.
Prefix with # instead to make it private?
There was a problem hiding this comment.
We'd need to update the shared eslint configuration and that's outside the scope of this PR.
ptpaterson
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Over the past few weeks, we've racked up quite a few npm linting warnings.
Solution
Transfer TODOs into actionable issues, and fix complexity complaints.
Result
Clean bill of health.
Testing
No tests have been harmed as part of these changes.