Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --typechecked help text #544

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Improve --typechecked help text #544

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc8c5bb
Improve `--typechecked` help text
jrodewig Dec 18, 2024
13661aa
Remove unneeded text for local
jrodewig Dec 18, 2024
87846b3
Add default for `local`
jrodewig Dec 18, 2024
55a205f
Default fauna local --typechecked to true but only when --database is…
ecooper Dec 18, 2024
561b654
Update src/commands/local.mjs
jrodewig Dec 18, 2024
d0cf63c
Merge branch 'v3' into improve-typecheck-help-text
ecooper Dec 18, 2024
71cdb0b
Merge branch 'v3' into improve-typecheck-help-text
ecooper Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/database/create.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function buildCreateCommand(yargs) {
typechecked: {
type: "boolean",
description:
"Enable typechecking for the database. Defaults to the typechecking setting of the parent database.",
"Enable typechecking for the database. Use --no-typechecked to disable. Defaults to enabled for top-level databases. Inherits the parent database's setting for child databases.",
},
protected: {
type: "boolean",
Expand Down
3 changes: 2 additions & 1 deletion src/commands/local.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,9 @@
},
typechecked: {
describe:
"Enable typechecking for the database. Valid only if --database is set.",
"Enable typechecking for the database. Use --no-typechecked to disable. Valid only if --database is set.",
jrodewig marked this conversation as resolved.
Show resolved Hide resolved
type: "boolean",
default: true,
ecooper marked this conversation as resolved.
Show resolved Hide resolved
},
protected: {
describe:
Expand Down Expand Up @@ -198,7 +199,7 @@
type: "boolean",
},
})
.check((argv) => {

Check warning on line 202 in src/commands/local.mjs

View workflow job for this annotation

GitHub Actions / lint 

Arrow function has a complexity of 11. Maximum allowed is 10
if (argv.maxAttempts < 1) {
throw new ValidationError("--max-attempts must be greater than 0.");
}
Expand Down
Loading