Remove --active --no-input flags from fauna local #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleve-fauna
approved these changes
Dec 17, 2024
ecooper
force-pushed
the
v3-always-active
branch
from
58e0963 to
6e50103
Compare
ecooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fauna localallows you to push a schema while bootstrapping. You need to manually confirm it, and that feels a little weird given the context of the command.Solution
Remove
--inputand--activefrom the command, but setinputtofalseandactivetotruewhen callingpushSchema.Result
Schema is pushed to the current active schema without a prompt.
Testing
The existing tests where updated to match the new behavior.