Remove missed --raw reference in faunadbToCommandError #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
requested review from
ptpaterson,
mwilde345,
jrodewig,
cleve-fauna and
henryfauna
jrodewig
approved these changes
Dec 16, 2024
ptpaterson
approved these changes
Dec 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-###
Problem
faunadbToCommandErrorwas still referencingraw. While it didn't break anything we should remove it sincerawis no longer a CLI option. Color wasn't always being obeyed in this code path.Solution
Refactor function interface to be an object. Always pass
color. No longer passraw.Result
Everything just works.