-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE-6254 Setting schema on 'fauna local --database Foo' #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleve-fauna
changed the title
FE-6254 Boilerplate for setting schema on 'fauna local --database Foo'
FE-6254 Setting schema on 'fauna local --database Foo'
Dec 16, 2024
mwilde345
reviewed
Dec 16, 2024
ecooper
requested review from
echo-bravo-yahoo,
henryfauna,
mryan-fauna and
jrodewig
and removed request for
mryan-fauna
December 17, 2024 00:08
henryfauna
approved these changes
Dec 17, 2024
jrodewig
approved these changes
Dec 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
fauna local
, it's likely you'll want to spin up a database and commit the current schema if the disks are ephemeral. We already let you create a fresh db when usingfauna local
. We should allow you to push FSL at this time too.Solution
Add the flags required to push schema to the database being created when running
fauna local
with one major changes:--active
is true by default infauna local
.This change in behavior compared to
fauna schema push
is required to enable a seamless "one command" way to run fauna locally against a local database. Otherwise, you'd runfauna local
and it would do everything other than commit the db changes.Given the interactive prompt is still turned on, some protections are in place in case this isn't something someone wants to do.
Result
Too big for a screenshot: