Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally, create a db when starting a local container #525

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Conversation

cleve-fauna
Copy link
Contributor

@cleve-fauna cleve-fauna commented Dec 13, 2024

Problem

Inner dev loops will be fastest if the user can:

  1. start a Fauna container
  2. create a database in that container
  3. deploy a schema to that database

with a single command.

Right now we only support (1).

Solution

Implement support for (2).

Do so by creating the requested DB if it doesn't exist, succeeding if it already exists with desired properties, failing if it exists but with different properties.

Result

We got some tooling in place for supporting inner dev loops.

Testing

Ran the tests; including new ones for happy and failure paths for creating a db.

@cleve-fauna cleve-fauna marked this pull request as ready for review December 13, 2024 22:15
@cleve-fauna cleve-fauna requested a review from a team as a code owner December 13, 2024 22:15
src/commands/local.mjs Outdated Show resolved Hide resolved
@cleve-fauna cleve-fauna requested a review from a team December 14, 2024 01:32
@cleve-fauna cleve-fauna merged commit c97f35f into v3 Dec 14, 2024
4 checks passed
@cleve-fauna cleve-fauna deleted the v3_createDb branch December 14, 2024 02:08
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants