Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete --raw flag #522

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Delete --raw flag #522

merged 2 commits into from
Dec 13, 2024

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Dec 13, 2024

Ticket(s): FE-6246

Problem

Feedback from our attempts at the --extra and --raw flag has been that they never really worked intuitively. It's not clear how QuerySuccess data should be formatted. We only have driver output, so what we have to display are not "raw" HTTP responses.

The current --raw flag is trying to work at two separate goals:

  1. display additional query info to the user
  2. give the user access to the underlying response

The --raw flag did an okay job at showing query info, but as a JSON output, makes the FQL/"decorated" format unreadable. There is no good/reliable way, yet, to get the raw response body for the user.

Solution

Remove the --raw option.

Future plans

  • add option to print query info like we do with performance hints and summary (rework --summary?)
  • add verbosity component for spying on the fetch and printing the HTTP response via existing debugging flags

Result

No more --raw option.

Testing

Remove tests that cared about --raw.

@ptpaterson ptpaterson requested a review from a team as a code owner December 13, 2024 15:21
@ptpaterson ptpaterson merged commit d2fa949 into v3 Dec 13, 2024
4 checks passed
@ptpaterson ptpaterson deleted the fe-6246-delete-raw branch December 13, 2024 21:40
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants