Gussy Up fauna status
#521
Open
+93
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
reviewed
Dec 13, 2024
Comment on lines
+75
to
+80
| if (statusResponse.status === "ready" && statusResponse.diff) { | ||
| logLineWithTab("(use `fauna schema commit` to commit staged changes)"); | ||
| logBlockWithTab(statusResponse.diff); | ||
| } else if (statusResponse.pending_summary) { | ||
| logBlockWithTab(statusResponse.pending_summary, 1); | ||
| } |
There was a problem hiding this comment.
I like how the diff is displayed for local changes and ready staged changes. Do you think there is a clear way to include the diff when reporting pending changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the output from
fauna schema status. Up for debate whether these changes actually make the output better.Examples
Local Changes
Pending Staged Changes
Ready Staged Changes
