Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use a default profile #514

Merged
merged 3 commits into from
Dec 12, 2024
Merged

don't use a default profile #514

merged 3 commits into from
Dec 12, 2024

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Dec 12, 2024

Ticket(s): FE-6232

Problem

If we find a config file in the default location, we assume they want to use it with at least the "default" profile, but they may not always want to use the config.

Solution

Provide a way to not use the config, by requiring a profile if a config is found. Essentially removing the "default" profile

Result

  1. Config is provided (via flag or env) -> require profile via flag or env.
  2. Config is not provided but is present in default location -> ignore the file if no profile is specified.
  3. Config is not provided and not in default location -> error if profile is provided

Testing

Updated existing tests

added test to ensure default config is ignored properly

@mwilde345 mwilde345 requested a review from a team as a code owner December 12, 2024 15:40
@ptpaterson ptpaterson requested a review from a team December 12, 2024 15:53
@mwilde345 mwilde345 requested a review from ptpaterson December 12, 2024 16:02
@mwilde345 mwilde345 merged commit 45ddf9c into v3 Dec 12, 2024
4 checks passed
@mwilde345 mwilde345 deleted the fe-6232 branch December 12, 2024 16:51
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants