Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if port for local Fauna is already occupied. Allow users to control hostIp. #512

Merged
merged 11 commits into from
Dec 13, 2024

Conversation

cleve-fauna
Copy link
Contributor

@cleve-fauna cleve-fauna commented Dec 12, 2024

Ticket(s): FE-5990

Problem

  • If the hostPort is already occupied by a process that is not the desired container with the desired name we should show a clear error.
  • users might want to control the hostIp
  • health check not tested
  • If a container with the desired name already exists but is on a different port show an error.

Solution

  • Detect when hostPort already occupied and show a clear error.
  • Allow tweak of hostIp
  • test health check

Testing

Ran all the tests

@cleve-fauna cleve-fauna marked this pull request as ready for review December 12, 2024 22:23
@cleve-fauna cleve-fauna requested a review from a team as a code owner December 12, 2024 22:23
@cleve-fauna cleve-fauna changed the title Tests for health checks. Detect if port for local Fauna is already occupied. Allow users to control hostIp. Dec 12, 2024
@cleve-fauna cleve-fauna merged commit 2b9c521 into v3 Dec 13, 2024
4 checks passed
@cleve-fauna cleve-fauna deleted the v3_local branch December 13, 2024 14:36
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants