Handle No Local Schema Files #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryfauna
force-pushed
the
no-local-schema
branch
from
fd3a7cc to
454c665
Compare
ptpaterson
reviewed
Dec 11, 2024
ptpaterson
reviewed
Dec 11, 2024
src/commands/schema/status.mjs
Outdated
| const gatherFSL = container.resolve("gatherFSL"); | ||
| const fsl = reformatFSL(await gatherFSL(argv.dir)); | ||
|
|
||
| const hasLocalSchema = fsl.entries().next().done === false; | ||
|
|
||
| const statusParams = new URLSearchParams({ diff: "summary" }); |
There was a problem hiding this comment.
There is no diff param documented for /status or /diff endpoints. Maybe that's an old value? Is the format: "summary" the param you want?
There was a problem hiding this comment.
Can confirm — format is the new alias for diff.
There was a problem hiding this comment.
cool - I've updated the command to use format as well as the expectation in the tests
ecooper
approved these changes
Dec 11, 2024
jrodewig
approved these changes
Dec 11, 2024
Co-authored-by: James Rodewig <[email protected]>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6217
Problem
When no local schema files are found
schema statustells the user that everything will be removed.Solution
Detect if no files were found and output a message to that effect instead.
Result
Users will know that they have specified the wrong schema directory.
Testing
Updated & added tests.