Clean up output formatting and support colorizing FQL results #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
reviewed
Dec 9, 2024
Conflicts: src/commands/query.mjs src/commands/shell.mjs src/lib/fauna-client.mjs src/lib/fauna.mjs src/lib/faunadb.mjs src/lib/misc.mjs test/query.mjs
mwilde345
approved these changes
Dec 10, 2024
ecooper
force-pushed
the
v3-data-formats
branch
from
d63843a to
1e8efc1
Compare
henryfauna
approved these changes
Dec 10, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not support copy-pasta FQL in shell and query.
Solution
Use shiki and port over its codeToANSI function so it can support custom languages.
However by supporting FQL rendering, nearly all the tests broke. So while I was here:
argvdev command for testing when you just want to prove argvResult
When outputting non-text, you can pass it to
colorizewith a format and it will format it.Testing
All tests needed to be updated to support fql by default.