[FE-6195] Disable JS Completions

[henryfauna]

Ticket(s): FE-6195

Problem

Setting completer: undefined when we set up the repl means we default to JS completions. This is why you can get things like:

setTimeout is of course not a function in Fauna. Previously the shell would parse the expression and catch the appropriate error code to avoid logging these sorts of errors. See here:

fauna-shell/src/commands/shell.js

Line 109 in 1c5153c

const res = esprima.parseScript(`(${cmd})`);

Solution

Disable JS completions as these don't make sense here.

Testing

Behold typing Time. does not blow up:

[echo-bravo-yahoo]

So, we technically do lose functionality here vs the old CLI:

I'm not sure I care, given that FQL v4 is on the deprecation path.

[henryfauna]

Yeah your right - let me take a closer look

[echo-bravo-yahoo]

the way the old code works is by making a nodeJS sub-vm with a context object that only contains the names defined in v4 syntax. so, setTimeout isn't a suggestion because setTimeout isn't defined as a global var in the sub-vm that evaluates completions.

https://nodejs.org/api/vm.html#scriptruninnewcontextcontextobject-options

[henryfauna]

Okay I think v4 completions should be back -

[echo-bravo-yahoo]

awesome, thank you for looking into it!