Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast succeed login when --local arg is given #489

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

cleve-fauna
Copy link
Contributor

@cleve-fauna cleve-fauna commented Dec 6, 2024

Problem

There's no need to try to do any login when running against a local.

Solution

Fast succeed.

Testing

Ran the tests and the command:

Screenshot 2024-12-06 at 3 53 07 PM

@cleve-fauna cleve-fauna requested a review from a team as a code owner December 6, 2024 20:52
@mwilde345 mwilde345 merged commit 88b3a22 into v3 Dec 9, 2024
4 checks passed
@mwilde345 mwilde345 deleted the v3_noLoginLocal branch December 9, 2024 15:31
@mwilde345 mwilde345 mentioned this pull request Dec 10, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants