Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --dir option from schema commands that don't use it #484

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

echo-bravo-yahoo
Copy link
Collaborator

Ticket(s): FE-6207

@echo-bravo-yahoo echo-bravo-yahoo requested a review from a team as a code owner December 5, 2024 20:35
@ptpaterson
Copy link
Contributor

Still needed for pull, too, right?

@jrodewig
Copy link
Contributor

jrodewig commented Dec 5, 2024

Still needed for pull, too, right?

Yeah — It tells you where to put the files you pull.

@echo-bravo-yahoo
Copy link
Collaborator Author

Thanks - good catch @ptpaterson @jrodewig!

As a bonus, the tests failed in a nice, localized way :)

@echo-bravo-yahoo echo-bravo-yahoo force-pushed the unnecessary-dir branch 2 times, most recently from e784271 to 508329f Compare December 5, 2024 22:59
@echo-bravo-yahoo echo-bravo-yahoo merged commit de234ba into v3 Dec 9, 2024
4 checks passed
@echo-bravo-yahoo echo-bravo-yahoo deleted the unnecessary-dir branch December 9, 2024 20:15
@mwilde345 mwilde345 mentioned this pull request Dec 10, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants