Suppress node warnings #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
force-pushed
the
suppress-node-warnings
branch
19 times, most recently
from
babc25c to
805ab4d
Compare
echo-bravo-yahoo
force-pushed
the
suppress-node-warnings
branch
2 times, most recently
from
2b6d0ca to
37670e0
Compare
this lets CI tests output both JUnit and spec reports. also changed the default "npm run test" to be local; CI now uses "npm run test:ci".
we want to ship dist/cli.cjs for customers. let's change this now.
this change: - configures ESbuild to rewrite "process.env.NODE_ENV" as "production" during build. - configures the CLI to remove warning event listeners (which include the built-in event listener that logs to stderr on warning) when run in production env.
echo-bravo-yahoo
force-pushed
the
suppress-node-warnings
branch
from
37670e0 to
bcbe238
Compare
henryfauna
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6079
fix packaging, prevent CLI from surfacing nodeJS warnings
the packaging config wasn't right (our npm package should include /dist, not /src, and the binary should be ./dist/cli.cjs, not ./src/user-entrypoint.mjs). this commit changes that.
additionally, nodeJS emits warnings for a variety of things (deprecation, dangling open resources, unusual resource usage). these look unprofessional in the middle of CLI runs. this change disables node's built-in warning logging in production builds only.