Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Schema body as FormData; Format schema test file #349

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Jul 24, 2024

Ticket(s): FE-5644

Problem

Schema tests run in the pipeline (but not in CircleCI). They failed: https://concourse.faunadb.net/teams/devex/pipelines/fauna-shell-release/jobs/test/builds/22

Solution

Schema endpoint expects Content-Type: multipart/form-data. We had that in place before, but swept through and updated all fetch calls to use ReadableStream. Just needed to revert back to FormData for the Schema portion.

Also applied some prettier to the schema test file

Result

➜  fsl git:(schema-test-fix) ✗ ./test-script.mjs ~/workplace/fauna-shell/bin/run
Schema tests run successfully!

Copy link
Contributor

@ecooper ecooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I crazy or is this like a 99% of this the first time these files have been linted/prettied?

@mwilde345 mwilde345 merged commit c1c4787 into main Jul 24, 2024
1 check passed
@mwilde345 mwilde345 deleted the schema-test-fix branch July 24, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants