Improved error catching and logging #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, we'll probably respond with a 410 (that's what we return right now on account disablement). |
freels
reviewed
Jul 5, 2024
src/lib/fauna-command.js
Outdated
Comment on lines
95
to
104
| } else if ( | ||
| err.description === "UnknownError" && | ||
| err?.requestResult?.statusCode === 410 && | ||
| version === "4" | ||
| ) { | ||
| this.error( | ||
| `This account is not allowed to query Fauna v4. Please use the v10 endpoint.` | ||
| ); | ||
| } else { | ||
| this.error(err); |
There was a problem hiding this comment.
This seems error prone, in that it assumes all unknown 410 errors are due to v4 being disabled. I think you should be able to get access to more error details via requestResult rather than relying on heuristics
There was a problem hiding this comment.
Ashton and I tested locally and found no reason not to just forward the nice message from core: https://github.com/fauna/core/blob/33ae43bb9aeabdea0f596020b0514975020dcf9b/ext/api/src/main/scala/api/ExceptionResponseHelpers.scala#L68
Updated this block to just properly handle description and message
mwilde345
changed the title
freels
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5448
Problem
Solution
err.messageanderr.descriptionfrom fauna. This will display the nice message from core regarding v4 accessevalwill properly catch errors from the asyncwrapQueriesblockResult
Testing