Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the examples in endpoint add #329

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix the examples in endpoint add #329

merged 2 commits into from
Nov 13, 2023

Conversation

jdcryans
Copy link
Contributor

Ticket(s): ENG-5723

Something that was missed in #263, key is now secret. h/t to @adambollen.

@jdcryans jdcryans requested a review from macmv November 13, 2023 22:15
macmv
macmv reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the README with python3 readme.py?

@jdcryans jdcryans merged commit 2ba90e8 into main Nov 13, 2023
@jdcryans jdcryans deleted the secretkey branch November 13, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macmv macmv macmv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdcryans @macmv