Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema from pipeline tests #327

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix schema from pipeline tests #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,18 @@ export class ShellConfig {
throw new Error(
`No endpoint or secret set. Set an endpoint in ~/.fauna-shell, ${PROJECT_FILE_NAME}, or pass --endpoint`
);
/**
* If there is no secret flag set we need to ensure we validate we can find a secret
* from the endpoint. Additionally if there is a root config present, we
* want to validate that things line up with the project. Even if a secret
* flag is set, there could be other properties of the endpoint that we need to
* pull in, url being the current one.
* The inverse of this is the running from a pipeline scenario where there is a secret
* set and no root config. In that case we don't want to validate the project configuration.
*/
} else if (this.secretFlag === undefined || !this.rootConfig.isEmpty()) {
this.projectConfig?.validate(this.rootConfig);
}
this.projectConfig?.validate(this.rootConfig);
};

lookupEndpoint = (opts: { scope?: string }): EndpointConfig => {
Expand Down