stack -> environment #324
Merged
stack -> environment #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made our endpoint validation a bit less rigid. This allows things like using fauna cloud-login when your project points to and endpoint that doesn't exist. Any command that needs a valid endpoint still ensures it has one and will print an error message conveying that. Added a custom help class so that we can display our beta topics below our non beta topics
macmv
reviewed
Nov 6, 2023
README.md
Outdated
|
|
||
| ARGUMENTS | ||
| DBNAME database name | ||
|
|
||
| FLAGS | ||
| --endpoint=<value> Connection endpoint, from ~/.fauna-shell | ||
| --secret=<value> Secret key. Overrides the `secret` in ~/.fauna-shell | ||
| --stack=<value> Stack to use, from a Fauna project | ||
| --environment=<value> environment to use, from a Fauna project |
There was a problem hiding this comment.
the README should be generated with the readme.py script, which will update this from the --help output.
| @@ -1,6 +1,6 @@ | |||
| schema_directory=schema | |||
| default=dev | |||
|
|
|||
| [stack.dev] | |||
| [environment.dev] | |||
There was a problem hiding this comment.
any plans to migrate the stack format to environment? I don't think its really worthwhile to add, I just realized that my fauna-shell file will be borked when I pull down this version.
There was a problem hiding this comment.
given we had only done the beta releases I was not planning to migrate them
src/commands/environment/select.ts
Outdated
| import { Args, Command } from "@oclif/core"; | ||
| import { ShellConfig } from "../../lib/config"; | ||
|
|
||
| export default class SelectenvironmentCommand extends Command { |
There was a problem hiding this comment.
Suggested change
| export default class SelectenvironmentCommand extends Command { | |
| export default class SelectEnvironmentCommand extends Command { |
| * the Help class from oclif/core and just override their sortedTopics() method. | ||
| * https://github.com/oclif/core/blob/main/src/help/index.ts#L67 | ||
| */ | ||
| export default class CustomHelp extends Help { |
There was a problem hiding this comment.
very cool, this change is nice to have.
macmv
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made our endpoint validation a bit less rigid. This allows things like using fauna cloud-login when your project points to and endpoint that doesn't exist. Any command that needs a valid endpoint still ensures it has one and will print an error message conveying that.
Added a custom help class so that we can display our beta topics below our non beta topics