don't validate endpoint config with --secret #315
Conversation
ENG-5661 This came up while I was testing updating schema in a pipeline. In this scenario the endpoints present in the project configuration won't exist, which is ok as long as a secret is getting passed.
src/lib/config/index.ts
Outdated
| @@ -250,7 +248,7 @@ export class ShellConfig { | |||
| ); | |||
| } | |||
|
|
|||
| if (endpointName === undefined) { | |||
| if (endpointName === undefined || secretFlag !== undefined) { | |||
There was a problem hiding this comment.
if you pass --secret, and endpointName is set, we need to pull the url and graphqlHost from that endpoint.
There was a problem hiding this comment.
I think this is a problem for our CD use case, there will be an endpoint set from the configuration file which sets the endpointName. so I guess what I'm looking for here is secret is set and the absence of a root config.
There was a problem hiding this comment.
right. so this change looks good, just the below part that says url: urlFlag should instead be url: urlFlag ?? endpoint.url or something.
There was a problem hiding this comment.
yeah that makes sense, but really I am targeting an empty root config scenario here, at least that was my intent, so I updated the check to account for that, lmk what you think
fauna-chase
force-pushed
the
secret-flag-no-endpoint
branch
from
304c26d to
6a237de
Compare
ENG-5661
This came up while I was testing updating schema in a pipeline. In this scenario the endpoints present in the project configuration won't exist, which is ok as long as a secret is getting passed.