Make --secret override project config #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauna-chase
approved these changes
Oct 16, 2023
Comment on lines
+19
to
26
| static parseFlag(key: string) { | ||
| if (key.length === 0) { | ||
| throw new Error("Secret cannot be empty"); | ||
| } | ||
| return new Secret({ key, allowDatabase: !key.includes(":") }); | ||
| } | ||
|
|
||
| static parse(key: string) { |
There was a problem hiding this comment.
wondering if we should just have one parse method, could take as a parameter whether or not the key can be scoped. Could use both of these methods under the hood. looking at 2 methods parse vs parseFlag may not be clear which to use but if we had an explicit parameter, allowScopedKey or something, then it may make it a bit more clear.
fauna-chase
reviewed
Oct 16, 2023
Comment on lines
30
to
32
| if (key.includes(":")) { | ||
| throw new Error("Secret cannot be scoped"); | ||
| } |
There was a problem hiding this comment.
my understanding here is that we wouldn't allow scoped secrets in the .fauna-shell file. I think that is fine, is backwards incompatible I believe though so could be a good thing for us to be aware of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): ENG-5650
I think this matches the feature matrix. I added some tests, and validated manually. We don't have mocks for the root/project config up, so I wasn't able to test all the combinations of things, but I'm mostly confident that its right :)