don't blow up for invalid config #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it such that commands emit warnings when invalid endpoints are detected in the fauna shell config. Users will still be able to use the shell if this is the case, all invalid endpoints will be ignored. As it currently stands, any attempt to update the fauna shell config file will fail if there are invalid endpoints as we would remove them in that scenario.
macmv
reviewed
Oct 11, 2023
macmv
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5603
This will make it such that commands emit warnings when invalid endpoints are detected in the fauna shell config. Users will still be able to use the shell if this is the case, all invalid endpoints will be ignored. As it currently stands, any attempt to update the fauna shell config file will fail if there are invalid endpoints as we would remove them in that scenario.