Add improved secret management #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauna-chase
reviewed
Oct 11, 2023
macmv
force-pushed
the
correct-secret-management
branch
2 times, most recently
from
930cea0 to
8675352
Compare
fauna-chase
reviewed
Oct 11, 2023
| return new Secret({ key, allowScope: !key.includes(":") }); | ||
| } | ||
|
|
||
| static parse(key: string) { |
There was a problem hiding this comment.
does the 'current' shell allow you to have endpoints in your file that are scoped?
[endpoint.child]
secret=secret:child:admin
secret=secret:child:@role/myrole
maybe we don't care? just trying to think through if this could lead to backwards incompatible changes for users and where we draw the line on that.
There was a problem hiding this comment.
the current shell lets you do that, but it will break if you set a database path in fauna eval or fauna shell. It seems like something we ought to just disallow.
fauna-chase
approved these changes
Oct 11, 2023
macmv
force-pushed
the
correct-secret-management
branch
from
77b1c44 to
0fd9144
Compare
macmv
force-pushed
the
correct-secret-management
branch
from
0fd9144 to
4c6d798
Compare
fauna-chase
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): ENG-5635
Adds a
Secrethelper class, which manages a scoped secret.This makes it so that
fauna shell <scope>will append the given scope to the scope in your project file. The behavior is a little weird:Note that it says "connected to database foo/bar", and then says "Starting shell for database bar."
Not sure if we want to fix this or not, but I think its fine as-is.