fix Connected to undefined message

[fauna-chase]

ENG-5630
This will display the endpoint and database being connected to when ever a CLI command is executed.

p4 » local-shell schema diff
Connected to endpoint: cli_test-us database: cli_bugbash
No schema differences

p4 » local-shell shell
Connected to endpoint: cli_test-us database: cli_bugbash
Type Ctrl+D or .exit to exit the shell
>

[fauna-chase]

copying my jira comment here:

the previous impl was just printing the url it was connecting to. I updated the current impl to do that, but do we think printing that url has any value? for customers it will always be https://db.fauna.com or localhost feels like we could just strip it out entirely.

One thing that does seem valuable is printing the database that is being connected to. Should we update it to do that?

[macmv]

I like the idea of printing the current endpoint and database that its connected to. URL seems nice to have too, if we can fit all 3 of those in that one-liner.

[macmv]

Suggested change

	`Could not Connect to ${connectionOptions.url} Unauthorized Secret`
	`Could not connect to ${connectionOptions.url}: unauthorized secret`

also it might be nice to print the secret there? not sure if we want to expose that though

[fauna-chase]

hmm yeah I'm not sure that we want to do that, my bias would be to just leave it out

[macmv]

sounds good to me

[fauna-chase]

I like the idea of printing the current endpoint and database that its connected to. URL seems nice to have too, if we can fit all 3 of those in that one-liner.

i updated this pr to print the current endpoint and database for every command. Also seems useful when doing schema commands and such

[macmv]

looks good to me, except for name being optional. IMO it should always be set.

[macmv]

style:

Suggested change

	name: name,
	name,

[fauna-chase]

looks good to me, except for name being optional. IMO it should always be set.

if you provide a secret as a flag we create an endpoint without a name.

[macmv]

oh yup nevermind