ENG-5593: Allow users to push non-logical changes #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickpintor
reviewed
Oct 9, 2023
src/commands/schema/push.js
Outdated
| this.log(`Proposed diff:\n`); | ||
| this.log(json.diff); | ||
| } else { | ||
| this.log("No logical changes to push"); |
There was a problem hiding this comment.
Idk if "logical" will resonate with users. Perhaps "No schema changes to push" or "No logical schema changes to push"?
There was a problem hiding this comment.
🤔 I think this is a word in common developer usage that people will understand, either immediately or with a moment's thought. Maybe I'll change it to "No logical changes. Push new file contents anyway?". Does that sound better?
There was a problem hiding this comment.
No logical changes. Push new file contents anyway?
My minor suggestion on that is to drop the word "new" as we'll be pushing the whole file instead of just the "new bits". Other that that, it looks pretty good to me.
The CLI disallowed pushing if there were no logical changes unless --force was set, but it's perfectly reasonable to push formatting and comment changes only. Now this will be allowed. I tested this manually. Here're samples of the workflow: $ fauna schema push --dir=$HOME/fsl Proposed diff: foo.fsl add collection Bar foo.fsl add collection Foo Accept and push changes? [no]: yes $ fauna schema push --dir=$HOME/fsl # Added a comment to Bar. No logical changes. Push file contents anyway? [no]: yes $ fauna schema push --dir=$HOME/fsl No logical changes. Push file contents anyway? [no]: no Push cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI disallowed pushing if there were no logical changes unless --force was set, but it's perfectly reasonable to push formatting and comment changes only. Now this will be allowed.
I tested this manually. Here're samples of the workflow:
$ fauna schema push --dir=$HOME/fsl
Proposed diff:
foo.fsl add collection Bar
foo.fsl add collection Foo
Accept and push changes? [no]: yes
$ fauna schema push --dir=$HOME/fsl # Added a comment to Bar.
No logical changes to push
Push anyway? [no]: yes
$ fauna schema push --dir=$HOME/fsl
No logical changes to push
Push anyway? [no]: no
Push cancelled