Re-implement cloud-login, using the new config #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcryans
reviewed
Oct 4, 2023
jdcryans
approved these changes
Oct 4, 2023
macmv
force-pushed
the
update-cloud-login
branch
from
bb4cbac to
f594a6b
Compare
wdberkeley
approved these changes
Oct 5, 2023
… auth endpoints in cloud-login
Co-authored-by: jdcryans <[email protected]>
macmv
force-pushed
the
update-cloud-login
branch
from
f594a6b to
5540dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): ENG-5578
Updates
cloud-loginto use the new ShellConfig class for updating the config.Email/password, with MFA are supported. Login through github/netlify are not. This matches the behavior before this PR.
Note that this command is not tested, and we don't have a library to test user interaction, so I haven't added tests. I did enable MFA and test out all the things manually, and it seems to be working well.