Cleanup endpoint commands #268

macmv · 2023-10-03T20:09:49Z

Ticket(s): ENG-5580

Adds a fauna endpoint topic, and updates commands to use the new shell config parsing.

New commands:

fauna endpoint add. This is aliased to fauna add-endpoint for compatibility.
fauna endpoint list. This is aliased to fauna list-endpoints for compatibility.
fauna endpoint remove. This is aliased to fauna delete-endpoint for compatibility.

src/commands/endpoint/list.ts

src/commands/endpoint/remove.ts

wdberkeley

LGTM. Would be nice to make the mood of the descriptions of all the commands be the same. Like I said in my comment, I prefer imperative, but indicate is OK.

src/commands/endpoint/list.ts

macmv added 4 commits October 3, 2023 11:33

Move endpoint commands into a topic, with aliases to the old commands

e86f0f3

Fix warning and log messages to use capitals and period

b362679

Add tests for the remaining endpoint commands

5d1a0b3

Fix linter things

27d761a

jdcryans reviewed Oct 3, 2023

View reviewed changes

src/commands/endpoint/list.ts Outdated Show resolved Hide resolved

src/commands/endpoint/remove.ts Outdated Show resolved Hide resolved

wdberkeley approved these changes Oct 3, 2023

View reviewed changes

src/commands/endpoint/list.ts Outdated Show resolved Hide resolved

Update to 'Compute the frustum of the wangledinger' (imperative mood)

bbe89e3

jdcryans approved these changes Oct 4, 2023

View reviewed changes

macmv merged commit e8b6a2d into main Oct 4, 2023

macmv deleted the cleanup-endpoint-commands branch October 4, 2023 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup endpoint commands #268

Cleanup endpoint commands #268

macmv commented Oct 3, 2023

wdberkeley left a comment

Cleanup endpoint commands #268

Cleanup endpoint commands #268

Conversation

macmv commented Oct 3, 2023

wdberkeley left a comment

Choose a reason for hiding this comment