Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --endpointURL flag #261

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Add --endpointURL flag #261

merged 4 commits into from
Sep 28, 2023

Conversation

macmv
Copy link
Contributor

@macmv macmv commented Sep 28, 2023

ENG-5530

Adds --endpointURL, and deprecates the old flags. I also chose to hide the old flags, as we really don't want new users to use them. So the old flags don't show up in --help, but they still exist and work as expected. Using the old flags will emit a warning though.

@macmv macmv requested a review from fauna-chase September 28, 2023 18:25
Copy link
Contributor

@fauna-chase fauna-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love that we can hide the params and they still work, nice!

src/lib/config/root-config.ts Show resolved Hide resolved
src/lib/config/root-config.ts Outdated Show resolved Hide resolved
@macmv macmv merged commit f860d85 into main Sep 28, 2023
@macmv macmv deleted the add-endpoint-url-flag branch September 28, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants