Store a ShellConfig in FaunaCommand #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macmv
force-pushed
the
store-config-in-fauna-command
branch
from
e346896 to
8102739
Compare
macmv
force-pushed
the
remove-args-from-shell-config
branch
from
c2a0ae6 to
2e13d99
Compare
macmv
force-pushed
the
store-config-in-fauna-command
branch
from
61d26da to
297436b
Compare
fauna-chase
reviewed
Sep 26, 2023
Comment on lines
+222
to
+229
| validate = () => { | ||
| if (this.endpoint === undefined) { | ||
| // No `~/.fauna-shell` was found, and no `--secret` was passed. | ||
| throw new Error( | ||
| "No endpoint or secret set. Set an endpoint in ~/.fauna-shell, .fauna-project, or pass --endpoint" | ||
| ); | ||
| } | ||
| }; |
There was a problem hiding this comment.
we do almost all of the validation in the constructor for this class and then just do the endpoint in the validate method. It seems that we are doing it this way because some commands don't require an endpoint. Which ones are those?
Given that it seems we are saying that this class is technically 'valid' without an endpoint. With that, I think I'd rather have the code paths that need it ensure there is an endpoint without this method on this class.
There was a problem hiding this comment.
yup, this should be renamed and refactored a bit to move more validation into here. i'll do that in a future PR
fauna-chase
approved these changes
Sep 27, 2023
…ts can use ShellConfig without setting an endpoint
macmv
force-pushed
the
store-config-in-fauna-command
branch
from
297436b to
5ad39e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-###
Stores a
ShellConfiginFaunaCommand, which will let us use the config in all the commands that need it.