Skip to content

Commit

Permalink
Default fauna local --typechecked to true but only when --database is…
Browse files Browse the repository at this point in the history
… set
  • Loading branch information
ecooper committed Dec 18, 2024
1 parent 87846b3 commit 55a205f
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions src/commands/local.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ async function createDatabase(argv) {
color,
}),
);

// In the docker container, typechecked will be false by default if not set.
// We need to set it to true if it's not set. We can't do it in the options,
// because we don't want to validate it unless --database is set.
let typechecked = argv.typechecked;
if (argv.database && argv.typechecked === undefined) {
typechecked = true;
}

try {
const db = await runQuery({
secret: "secret",
Expand All @@ -78,7 +87,7 @@ async function createDatabase(argv) {
let name = ${argv.database}
let database = Database.byName(name)
let protected = ${argv.protected ?? null}
let typechecked = ${argv.typechecked ?? null}
let typechecked = ${typechecked}
let priority = ${argv.priority ?? null}
if (database == null) {
Database.create({
Expand Down Expand Up @@ -169,7 +178,7 @@ function buildLocalCommand(yargs) {
describe:
"Enable typechecking for the database. Use --no-typechecked to disable. Valid only if --database is set.",
type: "boolean",
default: true,
default: undefined,
},
protected: {
describe:
Expand Down Expand Up @@ -208,7 +217,7 @@ function buildLocalCommand(yargs) {
"--interval must be greater than or equal to 0.",
);
}
if (argv.typechecked && !argv.database) {
if (argv.typechecked !== undefined && !argv.database) {
throw new ValidationError(
"--typechecked can only be set if --database is set.",
);
Expand Down

0 comments on commit 55a205f

Please sign in to comment.