Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT-4418] Add support to data types #30

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

pchitolina-fauna
Copy link

@pchitolina-fauna pchitolina-fauna commented Feb 1, 2024

Ticket(s): BT-4418

Problem

The library lacks serializer for data types.

Solution

This pull request introduces the methods for writing various data types, including integers, long integers, doubles, strings, dates, times and booleans.

Result

Added writting methods for data types.

Testing

Run unit tests in FaunaGeneratorTest class.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pchitolina-fauna pchitolina-fauna changed the title WIP: Add support to data types [BT-4418] Add support to data types Feb 1, 2024
Copy link
Collaborator

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but let's expand the time tests a bit.

@pchitolina-fauna pchitolina-fauna merged commit 8024e69 into dev Feb 13, 2024
1 check passed
@pchitolina-fauna pchitolina-fauna deleted the feature/BT-4418-faunagenerator-data-types branch February 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants