-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BT-4418] FaunaParser Long values #20
Merged
pchitolina-fauna
merged 11 commits into
dev
from
feature/BT-4418-utf8faunareader_read_long
Jan 31, 2024
Merged
[BT-4418] FaunaParser Long values #20
pchitolina-fauna
merged 11 commits into
dev
from
feature/BT-4418-utf8faunareader_read_long
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchitolina-fauna
changed the title
[BT-4418] Utf8FaunaReader Long values
[BT-4418] FaunaParser Long values
Jan 24, 2024
pnwpedro
requested changes
Jan 30, 2024
faunaJava/src/main/java/com/fauna/serialization/FaunaParser.java
Outdated
Show resolved
Hide resolved
faunaJava/src/test/java/com/fauna/serialization/FaunaParserTest.java
Outdated
Show resolved
Hide resolved
…t.java Co-authored-by: Lucas Pedroza <[email protected]>
Co-authored-by: Lucas Pedroza <[email protected]>
Base automatically changed from
feature/BT-4418-utf8faunareader_read_double
to
dev
January 31, 2024 14:29
pnwpedro
approved these changes
Jan 31, 2024
pchitolina-fauna
deleted the
feature/BT-4418-utf8faunareader_read_long
branch
January 31, 2024 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-4418
Merge after: #18
Problem
The current Fauna serialization module lacks a dedicated method to read values as Long.
Solution
Implemented specific logic for handling Fauna-specific token as Long.
Result
The addition of this capability enables the extraction and reading of tokens as Long, enhancing the functionality of the Fauna serialization module.
Testing
Run
Utf8FaunaReaderTest.java
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.